Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upvote cli fix #10683

Closed
wants to merge 1 commit into from
Closed

Upvote cli fix #10683

wants to merge 1 commit into from

Conversation

pahor167
Copy link
Contributor

Description

Fixes Cli when upvoting. Currently when proposal can be dequeued while upvoting, smart contract will revert. This change proactively dequeues proposals and only if the proposal way not dequeued, it will upvote it.

Other changes

No other changes

Tested

Added Upvote tests

Related issues

Backwards compatibility

Yes

@pahor167 pahor167 requested a review from a team as a code owner October 25, 2023 13:10
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: 6ad699a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add a changeset yarn changeset add which mentions this fix?

@pahor167
Copy link
Contributor Author

pahor167 commented Nov 6, 2023

#10704

@pahor167 pahor167 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants