Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upvode function #10268

Merged
merged 9 commits into from
May 19, 2023
Merged

Update upvode function #10268

merged 9 commits into from
May 19, 2023

Conversation

montera82
Copy link
Contributor

@montera82 montera82 commented Apr 19, 2023

Description

Added check to ensure upvote function does not proceed if proposalID is not even in the queue.

Tested

Scenario already covered by tests.

Related issues

Documentation

no need

@montera82 montera82 requested a review from a team as a code owner April 19, 2023 14:35
@montera82 montera82 requested a review from a team April 19, 2023 14:35
Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments 🚀

@montera82 montera82 enabled auto-merge (squash) May 17, 2023 15:01
@montera82 montera82 disabled auto-merge May 17, 2023 15:02
@montera82 montera82 enabled auto-merge (squash) May 18, 2023 18:57
@montera82 montera82 disabled auto-merge May 18, 2023 19:47
@montera82 montera82 merged commit ce75f49 into master May 19, 2023
@montera82 montera82 deleted the montera82/10091 branch May 19, 2023 12:33
montera82 added a commit that referenced this pull request May 19, 2023
@martinvol martinvol mentioned this pull request Jun 14, 2023
pahor167 added a commit that referenced this pull request Aug 1, 2023
pahor167 added a commit that referenced this pull request Aug 4, 2023
* Revert "Fix dequeueProposalIfReady() for expired proposals. (#10324)"

This reverts commit 890d195.

* Revert "Update upvode function (#10268)"

This reverts commit ce75f49.

* ReleaseGold refund test fix (#10440)

* ReleaseGold refund test fix

* gas fix

* Pahor/cli fix2 (#10457)

* ReleaseGold refund test fix

* gas fix

* PR comments

* removal of comment

* Cli fix 2

* Running GitHub Action workflow from release/* branches

* Fix regex

* Trigger protocol tests on release branches

* add logging

* lint fix

* uniswap test fix

* Trigger Identity tests too

---------

Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com>
@martinvol martinvol mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dequeueProposalsIfReady() should be at the bottom of methods
3 participants