Update Lock Gold Error Message "Not Account" #10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aram is missing or something.
|
Can we also update Accounts.sol since there is also quite few errors such as "Not an account" ? It will also be necessary to update getVersionNumber function |
yes will do! |
…nknown Account" with more descriptive and actionable messages
… "Unknown Account" with more descriptive and actionable messages
|
@pahor167 I went and updated places where error message as just let me know if this needs further changes. |
pahor167
approved these changes
May 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to lock celo many devs have ran into the reversion message "not account". this is ambiguous. often it seems like a param is missing or something.
Tested
Related issues
Backwards compatibility
i believe changes in error messages are not consider api changes
Documentation