Remove TransferWhitelist contract #10318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlb
force-pushed
the
karlb/remove-transfer-whitelist
branch
from
20662ce to
38705af
Compare
|
I think it's worth noticing that even if we delete the contract itself, our on-chain contract Registry does not have a function to remove, so the deployed implementation will keep being a core-contract. I do not see a downside with deleting the contracts, as it is already verified in Celo Explorer: https://explorer.celo.org/mainnet/address/0xb49E4d6F0B7f8d0440F75697E6c8b37E09178BCF/contracts#address-tabs |
eelanagaraj
reviewed
May 30, 2023
eelanagaraj
approved these changes
May 31, 2023
The current build failures are present in master. See
I can wait until master is green again and rebase then to get the the tests green. |
pahor167
reviewed
May 31, 2023
karlb
added a commit
that referenced
this pull request
May 31, 2023
since it is possible that someone will try to verify previous releases and since this contract is part of previous releases it might happen that verification will fail (or we should double check that it will not fail). See #10318 (comment).
karlb
force-pushed
the
karlb/remove-transfer-whitelist
branch
from
02357ab to
b2ab3c3
Compare
pahor167
approved these changes
May 31, 2023
karlb
added a commit
that referenced
this pull request
Jun 9, 2023
since it is possible that someone will try to verify previous releases and since this contract is part of previous releases it might happen that verification will fail (or we should double check that it will not fail). See #10318 (comment).
karlb
force-pushed
the
karlb/remove-transfer-whitelist
branch
from
b2ab3c3 to
3694a4d
Compare
The contract is not used anymore. See also celo-org/celo-blockchain#2110.
Otherwise the test fails when one of the migrations before the cUSD deployment changes.
since it is possible that someone will try to verify previous releases and since this contract is part of previous releases it might happen that verification will fail (or we should double check that it will not fail). See #10318 (comment).
karlb
force-pushed
the
karlb/remove-transfer-whitelist
branch
from
3694a4d to
1f5920d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract is not used anymore. See also celo-org/celo-blockchain#2110.