Combiner mem cache for DEK #10534
Merged
Combiner mem cache for DEK #10534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonponti
force-pushed
the
gastonponti/combiner-mem-cache
branch
from
9dab542 to
b4c575e
Compare
soloseng
approved these changes
Aug 31, 2023
| @@ -41,6 +41,8 @@ export const pnpFullNodeRetryCount = defineInt('PNP_FULL_NODE_RETRY_COUNT', { | |||
| export const pnpFullNodeDelaysMs = defineInt('PNP_FULL_NODE_DELAY_MS', { | |||
| default: RETRY_DELAY_IN_MS, | |||
| }) | |||
| export const pnpShouldMockAccountService = defineBoolean('PNP_SHOULD_MOCK_ACCOUNT_SERVICE') | |||
| export const pnpMockDek = defineString('PNP_MOCK_DECK') | |||
There was a problem hiding this comment.
could set a default DEK based on this
There was a problem hiding this comment.
Nice, I didn't know that. Adding it
There was a problem hiding this comment.
Mmm, I'll leave it like this. If I include that function I'll need to add a file in a test folder, which could be a problem for productive builds, or move that to some sort of utils, but just for testing.
If we use it as e2e we can set this variable and that's it
alecps
approved these changes
Sep 1, 2023
packages/phone-number-privacy/combiner/src/pnp/services/account-services.ts
Show resolved
Hide resolved
packages/phone-number-privacy/combiner/src/pnp/services/account-services.ts
Show resolved
Hide resolved
gastonponti
force-pushed
the
gastonponti/combiner-mem-cache
branch
from
b4c575e to
d7c3686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on PR #10533
LRU cache for the DEK of an account