Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify RTD packages #9421

Merged
merged 2 commits into from
Mar 29, 2022
Merged

specify RTD packages #9421

merged 2 commits into from
Mar 29, 2022

Conversation

critesjosh
Copy link
Contributor

Description

Recent builds of the typedoc autogenerated docs have been failing because of some dependency upgrades. This PR specifies the packages for the read the docs site to use so the build will work.

Related issue, readthedocs/readthedocs.org#9037

fail_on_warning: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we didnt fail on warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's an option. seems better to make packages explicit and fail on warnings though, so we can address them as they come up.

@critesjosh critesjosh requested a review from a team as a code owner March 29, 2022 19:08
@critesjosh critesjosh added the automerge Have PR merge automatically when checks pass label Mar 29, 2022
@mergify mergify bot merged commit 53650c7 into master Mar 29, 2022
@mergify mergify bot deleted the critesjosh/sdk-docs-build branch March 29, 2022 19:18
martinvol pushed a commit that referenced this pull request Sep 15, 2022
### Description

Recent builds of the typedoc autogenerated docs have been failing because of some dependency upgrades. This PR specifies the packages for the read the docs site to use so the build will work.

Related issue, readthedocs/readthedocs.org#9037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants