SDK support for StableTokenRegistry #9601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 25, 2022 12:01
…ze/sdk-StableTokenRegistry
…ze/sdk-StableTokenRegistry
ninabarbakadze
changed the base branch from
ninabarbakadze/stable-token-registry
to
master
pedro-clabs
reviewed
Jul 7, 2022
Co-authored-by: pedro-clabs <77401336+pedro-clabs@users.noreply.github.com>
…ub.com/celo-org/celo-monorepo into ninabarbakadze/sdk-StableTokenRegistry
martinvol
added a commit
that referenced
this pull request
Sep 21, 2022
* initial contract creation * added a contructor and a mapping * added function that add fiat tickers into the collection * function that returns all the fiat symbols thats been issued * quering a stable contract functionality * function to retrieve all the contract instances from a mapping * removing unnecessary imports * function that returns all the contracts * added comments * removed unnecessary function * removed unnecessary function * functionality to remove unsupported tokens * function that adds new instances to the registry * poor indentation * resolving bugs * suggested improvements * writing initialize * updated inconsistent syntax * initialize function is implemented * some of the resolved compile errors * resolving compiler issues * last of compiler issues * upgrading removeStableToken funrction * updated registry * updated initialize function * removed commented out code * updated comments * created a proxy * updating build file * updated build file * initialize test suit * updating registry contract * first few tests are passing * remove stableToken function * resolving a mistake * resolving based on corrections * tests for remove function complete * test suit for adding contracts * tests pass * adding more arguments to compare * adding registry contract to the registry * registry migrations * unsaved changes * bug fixed in initialized and two more found it addnewstabletoken * refactoring get contracts function * converted to bytes and contract compiles * initialize function added to tests * 8 tests pass, refactoring the contract * latest * fixing bugs * everything works ✨ * added a contraxt query function + tests * lists all the correct contract namea after adding and removing one ✨😭 * all functions are fully tested and work * adding it to the registry * finished * fixed migrations * amount of arguments in initialize error fixed * bug * had an accidental type in reserve * migration tests pass * one minor fix needed * removed from registry * readded in registry-utils * upgraded the number of migration file the tests should run to * cleaning up * applying suggestions * skeleton * more configs * added methods * type error in queryStableTokenContractNames * adding a helper * getContractInstances compiles * everything compiles * adding comments * added a function that returns fiatTickers * sdk tests * error in ts wrapper * fixed migration error * tests pass * fix lint * more lint fix * Delete release9.json * improved naming * Update packages/sdk/contractkit/src/wrappers/StableTokenRegistry.ts Co-authored-by: pedro-clabs <77401336+pedro-clabs@users.noreply.github.com> * post-review changes * cleanup * refactoring getFiatTicker function * Update StableTokenRegistry.sol Co-authored-by: Nina Barbakadze <ninabarbakadze@macbook-pro-4.localdomain> Co-authored-by: Nina Barbakadze <ninabarbakadze@MacBook-Pro-4.local> Co-authored-by: Nina Barbakadze <ninabarbakadze@vd47kwk70w.localdomain> Co-authored-by: Martín Volpe <volpe@clabs.co> Co-authored-by: pedro-clabs <77401336+pedro-clabs@users.noreply.github.com>
ninabarbakadze
added a commit
that referenced
this pull request
Nov 28, 2022
This reverts commit 5f38b4f.
alecps
added a commit
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
providing sdk support for on-chain stable token registry
Related issues