Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignores gasCurrency when passed to the config #198

Merged
merged 7 commits into from
Mar 25, 2024
Merged

feat: ignores gasCurrency when passed to the config #198

merged 7 commits into from
Mar 25, 2024

Conversation

nicolasbrugneaux
Copy link
Contributor

Following the discussion we had, this:

  • ignores --gasCurrency when passed to config:set but prints a warning linking to a discussion
  • change StrongAddress | 'CELO' type to StrongAddress as CELO is the default if no flag is passed
  • adds a test for config:set
  • fix packages/cli/src/transfer-stable-base.ts to use the kit.connection.defaultFeeCurrency instead of reimplementing the same logic as packages/cli/src/base.ts

@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner March 25, 2024 13:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4791daa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@celo/celocli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nicolasbrugneaux nicolasbrugneaux changed the base branch from prerelease/mcrn to master March 25, 2024 13:37
@nicolasbrugneaux nicolasbrugneaux changed the base branch from master to prerelease/mcrn March 25, 2024 13:37
arthurgousset
arthurgousset reviewed Mar 25, 2024
View reviewed changes
packages/cli/src/commands/config/set.ts
)
if (gasCurrency) {
ux.warn(
`\nSetting a default gasCurrency has been removed from the config, you may still use the --gasCurrency on every command.\nDid you value this feature a lot and would like to see it back? Let us know at ${chalk.cyan(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@nicolasbrugneaux nicolasbrugneaux force-pushed the fix/gas-currency-config branch from 67568e0 to e5cf38a Compare March 25, 2024 14:06
aaronmgdr
aaronmgdr approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beaut

@nicolasbrugneaux nicolasbrugneaux merged commit 880a838 into prerelease/mcrn Mar 25, 2024
13 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the fix/gas-currency-config branch March 25, 2024 14:53
This was referenced Mar 25, 2024
Merged
Closed
@nicolasbrugneaux nicolasbrugneaux mentioned this pull request Mar 25, 2024
Merged
aaronmgdr pushed a commit that referenced this pull request Mar 26, 2024
@nicolasbrugneaux
Major Release (#200)
6e3372f 
- Remove stable token Inflation related methods and configs #186
- USDC related changes #151
- Added Ethereum-compatible legacy TXs support #182
- Update dependency cross-fetch to v3.1.5 [SECURITY] #168
- feat: ignores gasCurrency when passed to the config #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurgousset arthurgousset arthurgousset left review comments

@shazarre shazarre shazarre left review comments

@aaronmgdr aaronmgdr aaronmgdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasbrugneaux @shazarre @aaronmgdr @arthurgousset