Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to call epoch manger on l2. #521

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Feb 4, 2025

Description

function removed need to call alt

Other changes

no

Tested

removed functions that mocked the calls

How to QA

run the election:current command against alfajores

Related issues


PR-Codex overview

This PR focuses on enhancing the election command by integrating the EpochManager to fetch elected signers based on the environment (Cel2 or not), while also updating the tests to accommodate new data structures and mock implementations.

Detailed summary

  • Introduced epochManagerWrapper to fetch elected signers if isCel2 is true.
  • Updated the logic to retrieve signers based on the environment.
  • Removed legacy mocking for getCurrentValidatorSigners.
  • Enhanced test cases with new validator data and updated assertions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (f466314) to head (a76e14a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   76.58%   76.59%           
=======================================
  Files         248      248           
  Lines       10639    10643    +4     
  Branches     1693     1705   +12     
=======================================
+ Hits         8148     8152    +4     
+ Misses       2400     2354   -46     
- Partials       91      137   +46     
Components Coverage Δ
celocli 86.78% <100.00%> (+0.01%) ⬆️
sdk 68.96% <ø> (ø)
wallets 74.03% <ø> (ø)
viem-sdks 93.54% <ø> (ø)

@aaronmgdr aaronmgdr marked this pull request as ready for review February 7, 2025 08:37
@aaronmgdr aaronmgdr requested a review from a team as a code owner February 7, 2025 08:37
@aaronmgdr aaronmgdr enabled auto-merge (squash) February 7, 2025 08:37
@aaronmgdr aaronmgdr merged commit 8e43a6a into master Feb 7, 2025
37 of 50 checks passed
@aaronmgdr aaronmgdr deleted the aaronmgdr/current-election branch February 7, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update election:current to use the epochManager contract when querying the elected signers on L2
2 participants