Skip to content

Remove opentelemetry dependencies from common package #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

alvarof2
Copy link
Member

@alvarof2 alvarof2 commented Jan 18, 2024

Description

Removes @opentelemetry dependencies from common package.

Other changes

N/A

Tested

nvm use 18
corepack enable
yarn
yarn build
yarn test
cd apps/combiner && yarn test:e2e:staging
cd ../signer && yarn test:e2e:staging:0

Then, locally:

  • Manually bumped PATCH version in package.json for @celo/phone-number-privacy-common.
  • Manually bumped PATCH version in package.json for @celo/phone-number-privacy-signer and @celo/phone-number-privacy-common dependency.
  • Manually bumped PATCH version in package.json for @celo/phone-number-privacy-combiner and @celo/phone-number-privacy-common dependency.
  • Port-forward to grafana agent in port 14268
  • Run combiner in port 8081 with yarn start:docker:tracing and env. vars. export TRACING_SERVICE_NAME=alvaro-test-combiner and export TRACER_ENDPOINT=http://localhost:14268/api/traces
  • Run signer in port 8080 with yarn start:docker:tracing and env. vars. export TRACING_SERVICE_NAME=alvaro-test-signer and export TRACER_ENDPOINT=http://localhost:14268/api/traces
  • Call curl localhost:8080/status and curl localhost:8081/status.

Got these traces:

Related issues

Backwards compatibility

N/A

Documentation

N/A

@alvarof2 alvarof2 requested a review from a team as a code owner January 18, 2024 11:47
Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: d4062a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@celo/phone-number-privacy-common Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@soloseng soloseng merged commit 547e3f4 into main Jan 26, 2024
@soloseng soloseng deleted the chore/remove-opentelemetry-dependencies branch January 26, 2024 15:08
@soloseng soloseng linked an issue Feb 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove opentelemetry dependencies from common
2 participants