Remove opentelemetry dependencies from common package #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
@opentelemetry
dependencies from common package.Other changes
N/A
Tested
Then, locally:
package.json
for@celo/phone-number-privacy-common
.package.json
for@celo/phone-number-privacy-signer
and@celo/phone-number-privacy-common
dependency.package.json
for@celo/phone-number-privacy-combiner
and@celo/phone-number-privacy-common
dependency.yarn start:docker:tracing
and env. vars.export TRACING_SERVICE_NAME=alvaro-test-combiner
andexport TRACER_ENDPOINT=http://localhost:14268/api/traces
yarn start:docker:tracing
and env. vars.export TRACING_SERVICE_NAME=alvaro-test-signer
andexport TRACER_ENDPOINT=http://localhost:14268/api/traces
curl localhost:8080/status
andcurl localhost:8081/status
.Got these traces:
Combiner: https://clabs.grafana.net/goto/MARfSJcSR?orgId=1

Signer: https://clabs.grafana.net/goto/6SLAIJcSR?orgId=1

Related issues
Backwards compatibility
N/A
Documentation
N/A