DP-1723: Changelog #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiore
requested changes
Aug 28, 2023
CHANGELOG.MD
Outdated
|
|
||
| ## [Unreleased] - yyyy-mm-dd | ||
|
|
||
| Here we write upgrading notes for brands. It's a team effort to make them as |
There was a problem hiding this comment.
upgrading notes for brands
This is confusing for me. How are upgrade notes related to this Unreleased section?
There was a problem hiding this comment.
Sorry, i copied template from somewhere and left that. Removing content, but i think we should still keep Unreleased section, so with every PR we can add proper content, and with release we just add a version and date.
afiore
approved these changes
Aug 30, 2023
| ### Fixed | ||
|
|
||
| - Error logging for not successful file upload. | ||
| - Committing an offset for heterogeneous topics. |
There was a problem hiding this comment.
Should we expand a bit on this latter point? Maybe it would be more clear if we said something like:
Ensure offsets are correctly committed even when the source topic has heterogeneous schemas (e.g. RecordNameStrategy or
TopicRecordNameStrategy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.