core/connpool: pool iff conn confirms to syscall.Conn #890
Annotations
16 errors, 12 warnings, and 1 notice
🧭 Lint:
intra/bootstrap.go#L179
Error return value of `prev.Stop` is not checked (errcheck)
|
🧭 Lint:
intra/dialers/direct_split.go#L32
`strat` is a misspelling of `start` (misspell)
|
🧭 Lint:
intra/dialers/direct_split.go#L39
`strat` is a misspelling of `start` (misspell)
|
🧭 Lint:
intra/dialers/direct_split.go#L57
`strat` is a misspelling of `start` (misspell)
|
🧭 Lint:
intra/dialers/direct_split.go#L58
`strat` is a misspelling of `start` (misspell)
|
🧭 Lint:
intra/dialers/retrier.go#L153
`strat` is a misspelling of `start` (misspell)
|
🧭 Lint:
intra/dialers/retrier.go#L154
`Strat` is a misspelling of `Start` (misspell)
|
🧭 Lint:
intra/dialers/retrier.go#L156
`Strat` is a misspelling of `Start` (misspell)
|
🧭 Lint:
intra/dialers/retrier.go#L176
`strat` is a misspelling of `start` (misspell)
|
🧭 Lint:
intra/dialers/retrier.go#L182
`strat` is a misspelling of `start` (misspell)
|
🧬 Build:
intra/core/connpool.go#L375
error: Potential nil panic detected. Observed nil flow from source to dereference point:
|
🧬 Build
literal `nil` returned from `SyscallConn()` in position 0 when the error return in position 1 is not guaranteed to be non-nil through all paths
|
🧬 Build
result 0 of `SyscallConn()` returned from `SyscallConn()` in position 0
|
🧬 Build
returned as result 0 from interface method `Conn.SyscallConn()` (implemented by `splitter.SyscallConn()`)
|
🧬 Build
result 0 of `SyscallConn()` called `Read()` via the assignment(s):
|
🧬 Build
Process completed with exit code 3.
|
🧭 Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, golangci/golangci-lint-action@v3.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
🧭 Lint:
intra/backend/core_iptree.go#L7
package-comments: should have a package comment (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L21
var-naming: type IpTree should be IPTree (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L77
var-naming: func NewIpTree should be NewIPTree (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L96
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L146
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L231
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L279
unused-parameter: parameter 'v' seems to be unused, consider removing or renaming it as _ (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L298
unused-parameter: parameter 'k' seems to be unused, consider removing or renaming it as _ (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L339
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
🧭 Lint:
intra/backend/core_iptree.go#L361
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
🧬 Build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
🧬 Build
success
|