Refactor all things mk 2 #354

hussainmohd-a · 2021-08-10T17:41:39Z

New: Quick settings chips.
Added new icons to the settings page.
Bug fixes.
Code refractor.
Changes in log statements.
Removed unwanted code comments.
Changes in code comments.

(cherry picked from commit 517e70d)

New: Quick settings chips. Added new icons to the settings page. Bug fixes. Code refractor. Changes in log statements. Removed unwanted code comments. Changes in code comments. (cherry picked from commit 517e70d)

Delete binary files (cherry picked from commit e40cc8b)

Firewall manager's local cache is modified from HashMultiMap to Multimaps.synchronizedMultimap(HashMultimap). Introducing read and write locks on app info local cache. (cherry picked from commit ba2e34e)

Code formatting on files. (cherry picked from commit f71f309)

Fix for turning off custom proxy was not happening in from Settings screen. Version name changed from v0.5.3f to v053f Addressed issue #352. Modified the minifyEnabled value to false in build.gradle file. Updating the label in home screen when the brave mode is modified. (cherry picked from commit 5ebd325)

Quick settings chips now has borders. (cherry picked from commit 117daca)

Send email feature (cherry picked from commit df52550)

Bug fix: Exclude app dialog select all option fix. (cherry picked from commit 2d1b766)

Play-services - dependency of play services API's is removed from the app, instead check if the play service package name is available in the package manager's application info. Bug fix for rethinkdns plus DoH update - Change in stamp not updated in Go tunnel. UI bug fix in Settings screen - Now the proxy UI's status will update based on both brave mode and VpnLockdown status. Changes in strings.xml for DNS mode and what's new text.

app/src/main/AndroidManifest.xml

app/src/main/java/com/celzero/bravedns/automaton/FirewallManager.kt

app/src/main/java/com/celzero/bravedns/util/OrbotHelper.kt

app/src/main/java/com/celzero/bravedns/util/Utilities.kt

With InetAddresses the conversion of byte array to IP address is done with LittleEndian. Now using InetAddress.getByAddress() from java.net.InetAddress #357

Code refractor. Removed / Changed unwanted code comments. Changes in variable or method names. Code simplification.

Removed unwanted code and modified code comments.

hussainmohd-a

Modified the above mentioned code comments.

app/src/main/java/com/celzero/bravedns/automaton/FirewallManager.kt

app/src/main/java/com/celzero/bravedns/data/AppMode.kt

ignoramous

Lets address the bug report zip with this commit.

app/src/main/java/com/celzero/bravedns/data/AppMode.kt

app/src/main/java/com/celzero/bravedns/database/RefreshDatabase.kt

app/src/main/java/com/celzero/bravedns/net/go/GoVpnAdapter.java

app/src/main/java/com/celzero/bravedns/ui/DNSLogFragment.kt

app/src/main/java/com/celzero/bravedns/util/Utilities.kt

app/src/main/java/com/celzero/bravedns/util/OrbotHelper.kt

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

app/src/main/java/com/celzero/bravedns/ui/DNSConfigureWebViewActivity.kt

app/src/main/java/com/celzero/bravedns/ui/HomeScreenActivity.kt

app/src/main/java/com/celzero/bravedns/service/PersistentState.kt

app/src/main/java/com/celzero/bravedns/ui/HomeScreenFragment.kt

app/src/main/java/com/celzero/bravedns/util/Constants.kt

app/src/main/java/com/celzero/bravedns/util/OrbotHelper.kt

app/src/main/java/com/celzero/bravedns/ui/SettingsFragment.kt

GoVpnAdapter modified from java to kotlin file. Firewall manager lock usage changed from ReenterantLock to ReadWriteLock. Modified modes to enum class. AppStatus, FirewallMode, DnsMode, Themes. Workmanager to collect app exit information. Work manager to refresh app database. Introduced new cache for dns resolved IPs. Changes in Pause timer. Network log bottom sheet UI changes. Added icons in drawable folder. Introduced new activity (Unused): DomainDetailActivity, DNSListActivity.

Changes to handle vpn in lockdown mode. When vpn is lockdown, modify brave mode to dns + firewall regardless of user set mode. disable option of changing brave mode when vpn in lockdown mode.

app/src/main/java/com/celzero/bravedns/adapter/ConnectionTrackerAdapter.kt

app/src/main/java/com/celzero/bravedns/ui/ExcludeAppsDialog.kt

app/src/main/java/com/celzero/bravedns/ui/SettingsFragment.kt

app/src/main/java/com/celzero/bravedns/ui/WhitelistAppDialog.kt

app/src/main/java/com/celzero/bravedns/util/Constants.kt

app/src/main/java/com/celzero/bravedns/util/KnownPorts.kt

New filter chips introduced in network log search view. Change in logic on restartVpn when the app is excluded from VPN. Usage of locks in FirewallManager is modified. Removed some unused methods from repository classes. New feature: Block newly installed apps. Bug report extraction logic modified. Modified logic of Pause timer long press (+ and -)

Added padding to the last element of the chip group so that the horizontal scrollview will load without trimming the last element's view.

ignoramous

Mostly minor comments.

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

app/src/main/java/com/celzero/bravedns/util/Constants.kt

app/src/main/java/com/celzero/bravedns/util/Themes.kt

app/src/main/java/com/celzero/bravedns/ui/SettingsFragment.kt

app/src/main/java/com/celzero/bravedns/viewmodel/ConnectionTrackerViewModel.kt

Changes in BraveVpnService coroutines usage. FirewallManager logic changes for AppStatus NotificationHandlerDialog - New dialog activity to take care of notification's activity launch. Other minor bug fixes and modifications.

app/src/main/java/com/celzero/bravedns/net/go/GoIntraListener.kt

app/src/main/java/com/celzero/bravedns/net/go/GoVpnAdapter.kt

app/src/main/java/com/celzero/bravedns/ui/NotificationHandlerDialog.kt

app/src/main/java/com/celzero/bravedns/ui/SettingsFragment.kt

app/src/main/java/com/celzero/bravedns/viewmodel/ConnectionTrackerViewModel.kt

Code refractor, addressed comments from #354

ignoramous

spotted some bugs, but majority of these are minor comments

app/src/main/AndroidManifest.xml

app/src/main/java/com/celzero/bravedns/NonStoreAppUpdater.kt

app/src/main/java/com/celzero/bravedns/adapter/CustomSpinnerAdapter.kt

app/src/main/java/com/celzero/bravedns/adapter/DNSCryptEndpointAdapter.kt

app/src/main/java/com/celzero/bravedns/adapter/DNSCryptRelayEndpointAdapter.kt

app/src/main/java/com/celzero/bravedns/util/Constants.kt

app/src/main/java/com/celzero/bravedns/util/OrbotHelper.kt

app/src/main/java/com/celzero/bravedns/service/IPTracker.kt

app/src/main/java/com/celzero/bravedns/ui/HomeScreenActivity.kt

addressed comments of #354

Quick Settings chips on the homescreen. Icons for all Settings on all pages. Coroutines instead of threads and associated improvements and mutexes (fixes) now that most files have moved to Kotlin. Fix LiveData observers (got rid of repeated calls to it from onResume of various ui-elements). Users can optionally view and email app-exit-info-reasons zip file. A WorkManager manager job collects these and zips them periodically. These are also collected on-demand, when the user clicks on 'bug report' button in the app. Introduce a ip-to-domain lookup based on recent queries the resolver has seen. It isn't fool-proof as using PTR queries but has proven useful regardless. Introduce pause-mode for the app. All apps except the ones blocked are exempt from the vpn for a certain time-period. New firewall rule: Block newly installed apps. Track new-apps lazily, as and when they send connections or whenever the WorkManager runs to detect all such newly installed apps. Tonne of other cosmetic code changes. Co-authored-by: Murtaza Aliakbar <murtaza@live.in>

hussainmohd-a added 8 commits August 10, 2021 23:08

Chips, Settings page refresh - v053f

7e28f2b

New: Quick settings chips. Added new icons to the settings page. Bug fixes. Code refractor. Changes in log statements. Removed unwanted code comments. Changes in code comments. (cherry picked from commit 517e70d)

Delete binary files

97ca6e9

Delete binary files (cherry picked from commit e40cc8b)

Changes in Firewall manager

f85ca57

Firewall manager's local cache is modified from HashMultiMap to Multimaps.synchronizedMultimap(HashMultimap). Introducing read and write locks on app info local cache. (cherry picked from commit ba2e34e)

Code format

4569ca5

Code formatting on files. (cherry picked from commit f71f309)

Quick setting chips border

f173a79

Quick settings chips now has borders. (cherry picked from commit 117daca)

Send email bug fix

52b4e18

Send email feature (cherry picked from commit df52550)

Exclude app bug fix

481b344

Bug fix: Exclude app dialog select all option fix. (cherry picked from commit 2d1b766)

hussainmohd-a changed the title ~~Post changes of v053f merge~~ v053f: Missing changes Aug 10, 2021

ignoramous requested changes Aug 13, 2021

View reviewed changes

hussainmohd-a added 3 commits August 18, 2021 14:04

Issue fix: IP address in reverse form

b04c507

With InetAddresses the conversion of byte array to IP address is done with LittleEndian. Now using InetAddress.getByAddress() from java.net.InetAddress #357

Code refractor, log statements

28faa46

Code refractor. Removed / Changed unwanted code comments. Changes in variable or method names. Code simplification.

Code comments

8cd0812

Removed unwanted code and modified code comments.

hussainmohd-a commented Aug 19, 2021

View reviewed changes

ignoramous reviewed Aug 20, 2021

View reviewed changes

ignoramous requested changes Aug 20, 2021

View reviewed changes

ignoramous reviewed Aug 20, 2021

View reviewed changes

ignoramous mentioned this pull request Aug 25, 2021

v053f missing from Github releases & F-Droid #359

Closed

ignoramous mentioned this pull request Sep 1, 2021

CPBL: Final list displays incorrectly in log view #362

Closed

hussainmohd-a added 2 commits September 4, 2021 23:40

Brave mode changes on Vpn lockdown mode

4f18fe1

Changes to handle vpn in lockdown mode. When vpn is lockdown, modify brave mode to dns + firewall regardless of user set mode. disable option of changing brave mode when vpn in lockdown mode.

hussainmohd-a mentioned this pull request Sep 7, 2021

java.lang.IllegalStateException: Can't access the Fragment View's LifecycleOwner when getView() is null #264

Closed

This was referenced Sep 7, 2021

[FEATURE REQUEST] Resolved IPs in network log #348

Closed

[Enhancement] Integrate Domain (PTR lookup) for IPs in Network Log #301

Closed

Replace AsyncTask with Workers #240

Closed

Logs from webview #365

Closed

ignoramous reviewed Sep 8, 2021

View reviewed changes

This was referenced Sep 8, 2021

Browser is bypassing firewall #364

Closed

Resolved IP being reversed in log-view #369

Closed

hussainmohd-a added 2 commits September 11, 2021 15:56

Exclude app dialog filter fix

5618f08

Added padding to the last element of the chip group so that the horizontal scrollview will load without trimming the last element's view.

ignoramous reviewed Sep 12, 2021

View reviewed changes

v053g: modifications

cd8541d

Changes in BraveVpnService coroutines usage. FirewallManager logic changes for AppStatus NotificationHandlerDialog - New dialog activity to take care of notification's activity launch. Other minor bug fixes and modifications.

ignoramous reviewed Sep 14, 2021

View reviewed changes

v053g: modifications

6f11734

Code refractor, addressed comments from #354

ignoramous mentioned this pull request Sep 16, 2021

Home Page Reports Incorrect DNS Config After DNS Connection Error #372

Closed

ignoramous reviewed Sep 16, 2021

View reviewed changes

app/src/main/java/com/celzero/bravedns/service/IPTracker.kt Outdated Show resolved Hide resolved

ignoramous reviewed Sep 16, 2021

View reviewed changes

app/src/main/java/com/celzero/bravedns/ui/HomeScreenActivity.kt Outdated Show resolved Hide resolved

v053g: modifications

df80440

addressed comments of #354

ignoramous mentioned this pull request Sep 18, 2021

Tunnel changes through single handler. #305

Closed

v053g: modifications

a80188a

addressed comments of #354

ignoramous changed the title ~~v053f: Missing changes~~ Refactor all thing mk 2 Sep 18, 2021

ignoramous changed the title ~~Refactor all thing mk 2~~ Refactor all things mk 2 Sep 18, 2021

minor changes

7a6bfb6

ignoramous merged this pull request into master Sep 19, 2021

ignoramous mentioned this pull request May 19, 2023

Fine tuning app instead of adding buggy features #911

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor all things mk 2 #354

Refactor all things mk 2 #354

hussainmohd-a commented Aug 10, 2021

hussainmohd-a left a comment

ignoramous left a comment

ignoramous left a comment

ignoramous left a comment

Refactor all things mk 2 #354

Refactor all things mk 2 #354

Conversation

hussainmohd-a commented Aug 10, 2021

hussainmohd-a left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment