Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add bs-fetch peer dependency to README #1

Closed
wants to merge 1 commit into from

Conversation

cem2ran
Copy link
Owner

@cem2ran cem2ran commented Oct 20, 2019

After teamwalnut#104 was merged, you have to explicitly install bs-fetch which may not be obvious to everyone until you try to compile and it fails:

File "bsconfig.json", line 1
Error: package bs-fetch not found or built 
- Did you install it?
- If you did, did you run `bsb -make-world`?
error Command failed with exit code 2.

So to avoid any friction in installing the library I think it's preferable to make this explicit in step 1 such that you are not met with the error when you try to compile.

@cem2ran cem2ran closed this Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant