Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Add support for cumulative. #1090

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Apr 3, 2019

No description provided.

@rghetia rghetia requested review from rakyll and a team as code owners April 3, 2019 18:30
metric/registry.go Outdated Show resolved Hide resolved
@rghetia rghetia requested a review from songy23 April 3, 2019 20:34
Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass.

metric/common.go Outdated Show resolved Hide resolved
metric/common.go Outdated Show resolved Hide resolved
metric/common.go Show resolved Hide resolved
metric/cumulative.go Outdated Show resolved Hide resolved
metric/cumulative.go Outdated Show resolved Hide resolved
metric/cumulative.go Outdated Show resolved Hide resolved
metric/cumulative.go Outdated Show resolved Hide resolved
Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rghetia rghetia merged commit a35ac18 into census-instrumentation:dev Apr 4, 2019
@rghetia rghetia deleted the cumulative branch April 15, 2019 20:43
rghetia added a commit to rghetia/opencensus-go that referenced this pull request Apr 25, 2019
* Add support for cumulative.

* fix review comments.
rghetia added a commit that referenced this pull request Apr 25, 2019
* Add support for cumulative.

* fix review comments.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants