-
Notifications
You must be signed in to change notification settings - Fork 327
add constant labels to gauges and cumulative metrics #1122
add constant labels to gauges and cumulative metrics #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paivagustavo thanks for the PR.
we are making commits to dev branch for now. I'll merge the dev branch to master just before the next release.
So can you please rebase your change to dev?
When you rebase, you will have conflict as I have created LabelKey type which contains key and description. So you will have to change that accordingly.
@rghetia I've rebased to dev and change the target branch (I may have pick some commits from the master that was not on dev yet, is it a problem?) While doing this, I noticed that the |
yes, that will be a problem. you can do |
Done, the PR now contains only the correct commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor nit. Otherwise LGTM.
…ntation#1122) * Remove unused GetEntry. * adds support for constant labels on Gauge and CumulativeMetric * fixing format on tests. * remove unused getentry
* Remove unused GetEntry. * adds support for constant labels on Gauge and CumulativeMetric * fixing format on tests. * remove unused getentry
This PR adds support for constant labels on gauges.
The proposed syntax is:
@rghetia this is my first contribution and as you were the one who created the issue, could you review this?
closes #1112