This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Added payload size to http server integration #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter, and modified example to use LogExporter
|
Partially addresses issue |
rghetia
approved these changes
Apr 24, 2019
plugin/ochttp/server.go
Outdated
| @@ -201,6 +207,9 @@ func (t *trackingResponseWriter) Header() http.Header { | |||
| func (t *trackingResponseWriter) Write(data []byte) (int, error) { | |||
| n, err := t.writer.Write(data) | |||
| t.respSize += int64(n) | |||
| // Add message event for request bytes read. | |||
There was a problem hiding this comment.
Corrected in latest commit
rghetia
pushed a commit
to rghetia/opencensus-go
that referenced
this pull request
Apr 25, 2019
…#1129) * Added payload size to http server integration, logged in the LogExporter, and modified example to use LogExporter * Fixed format problems * Corrected comment
rghetia
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Added payload size to http server integration, logged in the LogExporter, and modified example to use LogExporter * Fixed format problems * Corrected comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added payload size to http server integration, logged in the LogExporter, and modified example to use LogExporter