Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Revert "Allow replacing trace SDK (#1234)" #1235

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Revert "Allow replacing trace SDK (#1234)" #1235

merged 1 commit into from
Oct 23, 2020

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Oct 23, 2020

This reverts commit fc3822b.

This is causing a break in Google Cloud Functions, which depends on master when running in GOPATH mode.

See GoogleCloudPlatform/functions-framework-go#56.

Here is the error:

src/github.com/cloudevents/sdk-go/v2/extensions/distributed_tracing_extension.go:161:3: cannot use span (type trace.Span) as type *trace.Span in return argument:
	*trace.Span is pointer to interface, not interface; Error ID: 1093f764

@tbpg tbpg requested review from rghetia and a team as code owners October 23, 2020 14:15
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@tbpg
Copy link
Contributor Author

tbpg commented Oct 23, 2020

cc @nilebox @dashpole

@rghetia rghetia merged commit de37041 into census-instrumentation:master Oct 23, 2020
@nilebox
Copy link

nilebox commented Oct 25, 2020

@tbpg It seems that you're using the HEAD revision for some reason? The breaking change wasn't released yet AFAICT.
Can't you pin the dependency tag to v0.22.5?

@dashpole if we can come up with a backward compatible solution that would be preferred over the reverted change.
We can't expect every library to migrate to the latest OpenCensus release.

@tbpg
Copy link
Contributor Author

tbpg commented Oct 26, 2020

In GOPATH mode, you need some extra dependency/vendor management to depend on a specific version. We don't have that at the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants