Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Set up Github Actions for pull request validation #1237

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Set up Github Actions for pull request validation #1237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07cf3cd
First attempt at workflow migration.
jsuereth Oct 23, 2020
f24aaad
Update .github/workflows/build.yml
jsuereth Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Build

on:
pull_request:
branches:
- master

jobs:
build:
runs-on: ubuntu-20.04
env:
GO11MODULE: 'on'
steps:
- uses: actions/checkout@v2
with:
submodules: true
fetch-depth: 0 # we want all tags for version check.
lfs: true
- uses: actions/setup-go@v2
with:
go-version: '^1.11.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use something more recent. Maybe 1.14 or 1.15. I think GO11MODULE isn't needed after that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is matching what we had in Travis-CI. I'm not going to bump to 1.14/1.15 unless we're officially dropping support for older Go version here, which we're not. This is just a migration.

- name: Build and test
run: make install-tools && make travis-ci && go run internal/check/version.go