Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Allow replacing trace SDK; attempt 2 #1238

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

dashpole
Copy link
Collaborator

Second attempt at #1234.

This time, it is completely backwards-compatible--including with the handling of nil *Spans.

To accomplish this, we introduce a new Span struct, which wraps a SpanInterface implementation provided by the tracer.

@nilebox

trace/trace.go Show resolved Hide resolved
trace/trace_test.go Outdated Show resolved Hide resolved
@dashpole
Copy link
Collaborator Author

This should be good to go.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants