This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
Exporter/Zipkin: Add a note about status tags. #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
force-pushed
the
zipkin-status-tag
branch
from
b0a785d to
00da6e0
Compare
rghetia
approved these changes
Jun 11, 2019
|
opentracing !=zipkin so OT is not a valid rationale for zipkin data policy
especially when prior art exists.
since this is about zipkin I think we should use conventions present with a
comment saying where it was inherited from.
here is the default way we tag status for grpc. this has been the case
before opentracing did anything with grpc.
maybe correct and make a line note about why.
https://github.com/apache/incubator-zipkin-brave/blob/master/instrumentation/grpc/src/main/java/brave/grpc/GrpcParser.java#L67
thx
…On Wed, Jun 12, 2019, 1:01 AM Yang Song ***@***.***> wrote:
Suggested by #1928 (comment)
<#1928 (comment)>.
Seems this is the convention from OpenTracing.
/cc @adriancole <https://github.com/adriancole>
------------------------------
You can view, comment on, or merge this pull request online at:
#1931
Commit Summary
- Exporter/Zipkin: Update names of status tags.
File Changes
- *M*
exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java
<https://github.com/census-instrumentation/opencensus-java/pull/1931/files#diff-0>
(5)
- *M*
exporters/trace/zipkin/src/test/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandlerTest.java
<https://github.com/census-instrumentation/opencensus-java/pull/1931/files#diff-1>
(8)
Patch Links:
-
https://github.com/census-instrumentation/opencensus-java/pull/1931.patch
-
https://github.com/census-instrumentation/opencensus-java/pull/1931.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1931?email_source=notifications&email_token=AAAPVV6J3LZ6BBD25T5FUETPZ7K53A5CNFSM4HXA2AK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GY3X7ZQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPVV6DCQGFRVFJPYUS67DPZ7K53ANCNFSM4HXA2AKQ>
.
|
songy23
force-pushed
the
zipkin-status-tag
branch
from
00da6e0 to
b33460d
Compare
songy23
changed the title
|
@adriancole Thanks for the pointers. I reverted the changes to these tags and added a reference link. /cc @pjanotti |
|
|
||
| // The naming follows Zipkin convention. As an example see: | ||
| // https://github.com/apache/incubator-zipkin-brave/blob/643b7245c462dc14d47afcdb076b2603fd421497/instrumentation/grpc/src/main/java/brave/grpc/GrpcParser.java#L67-L73 | ||
| @VisibleForTesting static final String STATUS_CODE = "census.status_code"; |
There was a problem hiding this comment.
one important thing is that we do use non-ok as "error" message. this controls analysis etc, so I would recommend including this logic here.
There was a problem hiding this comment.
Got it, added in c1f588a.
pjanotti
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Thanks @songy23 for the code and @adriancole for providing the context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by #1928 (comment). Seems this is the convention from OpenTracing.
/cc @adriancole