-
Notifications
You must be signed in to change notification settings - Fork 202
Conversation
if (e.getLocalizedMessage() | ||
.startsWith( | ||
"io.grpc.StatusRuntimeException: UNAVAILABLE: HTTP/2 error code: NO_ERROR")) { | ||
continue; // Silently skip NO_ERROR Goaway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the exporter retry in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant on doing retry in this case, since I think NO_ERROR Goaway indicates server should have received and processed the request with no error. Retrying might generate duplicated stats and increase the burden of server.
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 81.8% 81.6% -0.2%
Complexity 1032 1032
==========================================
Files 169 169
Lines 4600 4611 +11
Branches 431 434 +3
==========================================
Hits 3763 3763
- Misses 730 741 +11
Partials 107 107
Continue to review full report at Codecov.
|
c082a3f
to
16afb30
Compare
Talked offline. I'll close this PR for now, until I can make sure this failure has no impact on the uploaded stats. |
Closes #869.
Based on the discussion in #869, I think it's safe to silently skip status UNAVAILABLE with error code NO_ERROR.