This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
feat: add package instrumentation-all to opencensus-node #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiogomessilva
force-pushed
the
pkg_instrumentation_all
branch
2 times, most recently
from
6421d86 to
99b4d04
Compare
kjin
reviewed
Jun 2, 2018
| * limitations under the License. | ||
| */ | ||
|
|
||
|
|
There was a problem hiding this comment.
We might as well re-export all instrumentation objects here. What do you think?
At the very least, this module could contain the value of DEFAULT_INSTRUMENTATION_MODULES.
There was a problem hiding this comment.
Good idea to export DEFAULT_INSTRUMENTATION_MODULES. Done !
fabiogomessilva
force-pushed
the
pkg_instrumentation_all
branch
from
5c7d32b to
a948e65
Compare
kjin
approved these changes
Jun 4, 2018
|
Merging this after #21. |
fabiogomessilva
force-pushed
the
pkg_instrumentation_all
branch
from
dd6a766 to
514c75f
Compare
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
…rumentation#22) * feat: add package instrumentation-all to opencensus-node * refactor: changes to address review comments
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
…rumentation#22) * feat: add package instrumentation-all to opencensus-node * refactor: changes to address review comments
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
…rumentation#22) * feat: add package instrumentation-all to opencensus-node * refactor: changes to address review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds package 'instrumentation-all' which has only dependencies to all default instrumentation packages.
This package will be a dependency for package @opencensus/nodejs, and its main goal is to avoid the end user to add these dependencies to their own package.