Use cls-hooked instead of continuation-local-storage #793
Conversation
oleg-codaio
requested review from
draffensperger,
hekike and
mayurkale22
as code owners
| @@ -1,174 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
cls-hooked already handles different versions of Node, so I don't think we need this.
| ? require('./cls-ah') | ||
| : require('continuation-local-storage'); | ||
| // eslint-disable-next-line no-any | ||
| export type Func<T> = (...args: any[]) => T; |
There was a problem hiding this comment.
Not a huge fan of the no-any bypass here, but I just took this definition from the original continuation-local-storage package. Open to suggestions, though.
|
Yikes, tests failed and looks this needs more work. Could be that this project or a dependency is interfering with queuing (https://github.com/nodejs/diagnostics/blob/master/tracing/AsyncHooks/problematic-modules.md), though I'm not at all familiar with this library and probably won't get to debugging in the near future. If anyone else with more familiarity has any ideas and a motivation to tackle this, please do. |
Closes #792.
Would appreciate a maintainer to verify that this PR works, as I'm not familiar with this package: just trying to fix a deprecation warning a few levels deep into dependencies.