You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm new to the dependency management in Python so this may be a naive question:
For the OC-Agent Exporter, we put the proto-generated Python files as a vendor under opencensus/trace/exporters/gen/opencensus. AFAIS this is not convenient since every time when we made a new release on OpenCensus-Proto, those gen-files need to be updated separately. This has also caused some trouble with Pylint before (#266 (comment)).
If possible, I think a better way is to host the generated Python files on OpenCensus-Proto, release them as separate Python library, and have the OC-Agent Exporter import it. Note that Go already did it.
That sounds good to me. Stackdriver Trace exporter also uses the same strategy, we host the auto-gen stackdriver trace Python files in google-cloud-python/trace, and release it to PyPI as google-cloud-trace library. Then it is used in stackdriver trace exporter.
songy23
changed the title
Question: is it possible not to vendor the proto-generated files?
Move proto-generated files to OpenCensus-Proto.
Sep 19, 2018
I'm new to the dependency management in Python so this may be a naive question:
For the OC-Agent Exporter, we put the proto-generated Python files as a vendor under opencensus/trace/exporters/gen/opencensus. AFAIS this is not convenient since every time when we made a new release on OpenCensus-Proto, those gen-files need to be updated separately. This has also caused some trouble with Pylint before (#266 (comment)).
If possible, I think a better way is to host the generated Python files on OpenCensus-Proto, release them as separate Python library, and have the OC-Agent Exporter import it. Note that Go already did it.
/cc @lmolkova @liyanhui1228
The text was updated successfully, but these errors were encountered: