Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move proto-generated files to OpenCensus-Proto. #318

Closed
songy23 opened this issue Sep 19, 2018 · 1 comment · Fixed by #596
Closed

Move proto-generated files to OpenCensus-Proto. #318

songy23 opened this issue Sep 19, 2018 · 1 comment · Fixed by #596

Comments

@songy23
Copy link
Contributor

songy23 commented Sep 19, 2018

I'm new to the dependency management in Python so this may be a naive question:

For the OC-Agent Exporter, we put the proto-generated Python files as a vendor under opencensus/trace/exporters/gen/opencensus. AFAIS this is not convenient since every time when we made a new release on OpenCensus-Proto, those gen-files need to be updated separately. This has also caused some trouble with Pylint before (#266 (comment)).

If possible, I think a better way is to host the generated Python files on OpenCensus-Proto, release them as separate Python library, and have the OC-Agent Exporter import it. Note that Go already did it.

/cc @lmolkova @liyanhui1228

@liyanhui1228
Copy link
Contributor

That sounds good to me. Stackdriver Trace exporter also uses the same strategy, we host the auto-gen stackdriver trace Python files in google-cloud-python/trace, and release it to PyPI as google-cloud-trace library. Then it is used in stackdriver trace exporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants