Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate ocagent proto files. #589

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Mar 29, 2019

Regenerate gen-proto files with the latest OpenCensus-proto, similar to #524. Everything is auto-generated by proto compiler except a few fixes in the import paths.

/cc @lmolkova

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@songy23
Copy link
Contributor Author

songy23 commented Mar 29, 2019

Ideally the proto generated files should be hosted at census-instrumentation/opencensus-proto#196 and we can remove opencensus-ext-ocagent/opencensus/ext/ocagent/trace_exporter/gen (tracked in #318). Once that's done we won't need to have PRs like this to update the gen files in this repo.

@reyang
Copy link
Contributor

reyang commented Mar 29, 2019

Ideally the proto generated files should be hosted at census-instrumentation/opencensus-proto#196 and we can remove opencensus-ext-ocagent/opencensus/ext/ocagent/trace_exporter/gen (tracked in #318). Once that's done we won't need to have PRs like this to update the gen files in this repo.

I agree with you! I actually suggested to @c24t that we should have the generated stuff as a standalone Python package, and release it automatically each time when we update the opencensus-proto. In this way if we want to take the new protocol, we can just update the package reference from the exporter.

@songy23 @c24t what's your thinking?

@songy23
Copy link
Contributor Author

songy23 commented Mar 29, 2019

I agree with you! I actually suggested to @c24t that we should have the generated stuff as a standalone Python package, and release it automatically each time when we update the opencensus-proto. In this way if we want to take the new protocol, we can just update the package reference from the exporter.

Yes, I'm currently working on it: census-instrumentation/opencensus-proto#196. Once I have the release set up in opencensus-proto, I'll come back and remove the gen-files in the Python repo.

@songy23 songy23 merged commit ab0b588 into census-instrumentation:master Mar 29, 2019
@songy23 songy23 deleted the update-gen-python branch March 29, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants