Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Make agent grpc-gateway work with grpc 1.18+ #501

Merged

Conversation

draffensperger
Copy link
Contributor

@draffensperger draffensperger commented Mar 26, 2019

The google.golang.org/grpc v1.18.0 release includes a change that made handshakes required by default. That when combined with the cmux multiplexer caused an "all SubConns are in TransientFailure" error message for HTTP calls made via grpc-gateway (see this issue comment for more details). The fix is to use a setting that cmux offers that handles the handshake correctly.

Our grpc 1.18 upgrade was rolled back in #503 so this is not immediately needed, but having it in place will make the grpc-gateway functionality continue to work once the grpc dependency is upgraded past 1.18.

See #492 - this will enable the grpc-gateway test to keep passing (and the functionality to keep working) after the future grpc upgrade.

@draffensperger draffensperger requested review from pjanotti and a team as code owners March 26, 2019 17:42
@draffensperger
Copy link
Contributor Author

cc/ @songy23

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #501 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   58.81%   58.81%           
=======================================
  Files          69       69           
  Lines        4507     4507           
=======================================
  Hits         2651     2651           
  Misses       1692     1692           
  Partials      164      164
Impacted Files Coverage Δ
receiver/opencensusreceiver/opencensus.go 65.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fed7f...31d4173. Read the comment docs.

@pjanotti
Copy link

@draffensperger we reverted grpc to 1.17.0 since there were other things broken. It looks like that we may skip v1.18.0 will this PR still be needed in this case?

@songy23
Copy link
Contributor

songy23 commented Mar 27, 2019

I'd suggest to put this PR on hold and merge it later once we roll forward the proto (and gRPC) updates.

@draffensperger draffensperger changed the title Fix grpc-gateway after grpc 1.18 upgrade Make agent grpc-gateway work with grpc 1.18+ Mar 27, 2019
@draffensperger
Copy link
Contributor Author

draffensperger commented Mar 27, 2019

The main thing I would like is for the agent grpc-gateway functionality to continue to work as future changes are made, since I'm using that for the opencensus-web project to write spans via HTTP.

I'm open to waiting until the grpc dependency is updated but then I'd like this change to be done in the same PR as the upgrade to preserve the functionality.

Given that, I actually think it would be simpler to just merge this now so that there will be one less thing to think about when upgrading to grpc 1.18 or 1.19. I updated the PR title and description to talk about this as a preparatory change for the upgrade rather than a fix.

@pjanotti
Copy link

Makes sense @draffensperger.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that, I actually think it would be simpler to just merge this now so that there will be one less thing to think about when upgrading to grpc 1.18 or 1.19. I updated the PR title and description to talk about this as a preparatory change for the upgrade rather than a fix.

SGTM

@songy23 songy23 merged commit f855869 into census-instrumentation:master Mar 28, 2019
@flands flands added this to the 0.2.0 milestone Mar 28, 2019
@draffensperger draffensperger deleted the fix-grpc-gateway branch March 28, 2019 14:00
fivesheep pushed a commit to fivesheep/opencensus-service that referenced this pull request Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants