Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): New seeds CLI commands #571

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Conversation

BobDickinson
Copy link
Contributor

Added several new seed commands to CLI, added CSV support

BobDickinson and others added 8 commits November 3, 2023 21:26
Added several new seed commands to CLI, added CSV support
Implemented multithreaded delete operations, fixed doc strings, fixed by when using Censys ASM exported CSV files, added --verbose to all commands
Also provided links to CLI command docs for each command.
Replace labeled seeds was adding the label to the seeds being added, which made the backend API mad.  Fixed test to detect, then fixed bug.
If file provided by name and --csv not specified, but file is .csv, treat it as CSV.
Delete should prefer value to ID if both are present (esp when recycling CSVs that have been output / edited and then later used as a delete source with potentially invalid IDs).
@BobDickinson BobDickinson changed the title New seeds CLI commands feat(cli): New seeds CLI commands Nov 9, 2023
Copy link
Contributor

@grace-murphy grace-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grace-murphy grace-murphy merged commit 204e8c8 into censys:main Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants