Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve pagination for asm search #643

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

grace-murphy
Copy link
Contributor

@grace-murphy grace-murphy commented Sep 5, 2024

Changes

  • Add --pages optional flag to asm search, asm execute-saved-query-by-id, and asm execute-saved-query-by-name to allow for easier pagination in the CLI. The default is 1. When set to -1, all pages will be returned.
  • Bump version to 2.2.14

@grace-murphy grace-murphy force-pushed the grace-murphy/asm-search-pagination branch from bb892a4 to b4c1a66 Compare September 6, 2024 16:49
Copy link
Member

@thehappydinoa thehappydinoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grace-murphy grace-murphy merged commit b270cb2 into main Sep 9, 2024
5 checks passed
@grace-murphy grace-murphy deleted the grace-murphy/asm-search-pagination branch September 9, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants