This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
enh(resources): in detail, fetch downtime only if needed #12032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adr-mo
requested review from
a team,
a-launois and
dmyios
and removed request for
a team
kduret
approved these changes
Oct 24, 2022
| 0 | ||
| ); | ||
| $resource->setDowntimes($downtimes); | ||
| if ($resource->getInDowntime() === true) { |
There was a problem hiding this comment.
we'll need to rename later getInDowtime by isInDowntime
There was a problem hiding this comment.
Yes I did not take the time to do it as multiple impacts which are not that mandatory as 21.10 will reach EOL soon
ghost
approved these changes
Nov 2, 2022
dmyios
approved these changes
Nov 2, 2022
|
SonarQube Quality Gate
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to only fetch downtimes for resources if needed !
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
See Jira ticket for thisChecklist
Community contributors & Centreon team