Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(ci): add pipeline for as400 using nfpm #5167

Merged
merged 40 commits into from
Sep 23, 2024

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Sep 4, 2024

Centreon team

Description

  • as 400 build
  • as 400 package (using nfpm)

Fixes #MON-34611

If you are fixing a github Issue already existing, mention it here.
If you are fixing one or more JIRA ticket, mention it here too.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Coming soon

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.

@tuntoja tuntoja changed the title Mon 34611 add plugin as400 build and packaging enh(ci): add pipeline for as400 using nfpm Sep 4, 2024
@garnier-quentin
Copy link
Contributor

garnier-quentin commented Sep 4, 2024

The doc part is totaly wrong (it's for the old as400 connector). You can remove it. The right doc is: https://docs.centreon.com/fr/pp/integrations/plugin-packs/procedures/operatingsystems-as400-connector/

@tuntoja
Copy link
Contributor Author

tuntoja commented Sep 4, 2024

The doc part is totaly wrong (it's for the old as400 connector). You can remove it. The right doc is: https://docs.centreon.com/fr/pp/integrations/plugin-packs/procedures/operatingsystems-as400-connector/

By doc I assume you meant the doc directory (as I noticed it was mentionning very old centreon versions)

@tuntoja tuntoja marked this pull request as ready for review September 11, 2024 13:18
@tuntoja tuntoja requested review from a team as code owners September 11, 2024 13:18
@tuntoja tuntoja requested a review from kduret September 17, 2024 14:06
kduret
kduret previously approved these changes Sep 17, 2024
@lucie-dubrunfaut lucie-dubrunfaut added the internal Centreon internal PR label Sep 23, 2024
@tuntoja tuntoja merged commit 53afb6e into develop Sep 23, 2024
21 checks passed
@tuntoja tuntoja deleted the MON-34611-add-plugin-as400-build-and-packaging branch September 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Centreon internal PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants