Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(plugin): add ansible host IP to Ansible Tower discovery #5221

Conversation

sdepassio
Copy link
Contributor

@sdepassio sdepassio commented Oct 4, 2024

Centreon team

Description

Add IP to the returned fields of discovery

Fixes # CTOR-311

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@sdepassio sdepassio marked this pull request as ready for review October 4, 2024 15:57
@sdepassio sdepassio requested review from a team as code owners October 4, 2024 15:57
@sdepassio sdepassio merged commit 591981b into develop Oct 7, 2024
21 checks passed
@sdepassio sdepassio deleted the CTOR-311-plugin-apps-automation-ansible-tower-mode-discovery-add-ip-to-the-returned-fields branch October 7, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants