Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): update undertow-io dependency to 2.3.17 #5226

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Oct 8, 2024

Centreon team

Description

  • bump dependency to 2.3.17

Fixes # (issue)
Fixes #MON-150297

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@tuntoja tuntoja changed the title bump fix(security): update undertow-io dependency to 2.3.17 Oct 8, 2024
@tuntoja tuntoja marked this pull request as ready for review October 10, 2024 08:28
@tuntoja tuntoja requested a review from a team as a code owner October 10, 2024 08:28
@tuntoja tuntoja requested review from omercier and vuntz October 10, 2024 08:28
sdepassio
sdepassio previously approved these changes Oct 10, 2024
Copy link
Contributor

@omercier omercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we wait until the next release

vuntz
vuntz previously approved these changes Oct 10, 2024
@omercier omercier dismissed their stale review October 11, 2024 07:58

Let's go now!

@tuntoja tuntoja dismissed stale reviews from vuntz and sdepassio via 11c926f October 11, 2024 08:08
@tuntoja tuntoja force-pushed the MON-150297-dep-upgrade-io-undertow-to-2-3-17-final-on-centreon-as-400-module branch from 404f8ba to 11c926f Compare October 11, 2024 08:08
@tuntoja tuntoja merged commit e5b6a29 into develop Oct 11, 2024
8 checks passed
@tuntoja tuntoja deleted the MON-150297-dep-upgrade-io-undertow-to-2-3-17-final-on-centreon-as-400-module branch October 11, 2024 08:26
omercier added a commit that referenced this pull request Oct 14, 2024
Co-authored-by: omercier <32134301+omercier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants