Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-106121-gorgone-vault-add-unit-test-libs #5265

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

Evan-Adam
Copy link
Contributor

Refs:MON-106121

Description

ARM was not built nor tested previously.
The new dependancy are for centreon-perl-libs-common in centreon repository. Gorgone will have some too in the future.

Fixes # (issue)
If you are fixing a github Issue already existing, mention it here.
If you are fixing one or more JIRA ticket, mention it here too.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

ARM was not built nor tested previously.
The new dependancy are for centreon-perl-libs-common in centreon repository. Gorgone will have some too in the future.

Refs:MON-106121
Refs:MON-106121
* fix yaml spaces inside bracket
* fix dockerfile ENV to use key=value
* use yath lastlog.jsonl link instead of the real filename as github can't process : in filename

Refs:MON-106121
@Evan-Adam Evan-Adam marked this pull request as ready for review October 29, 2024 09:49
@Evan-Adam Evan-Adam requested a review from a team as a code owner October 29, 2024 09:49
@Evan-Adam Evan-Adam merged commit 3629c94 into develop Oct 29, 2024
20 checks passed
@Evan-Adam Evan-Adam deleted the MON-106121-gorgone-vault-add-unit-test-libs branch October 29, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants