Feature/inputter-styles #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andij
commented
Jan 4, 2022
•
andij
commented
- initial styling for details component in the inputter
- initial styling for input 'elements and types' listed in Create inputter component #28
- include a technique to replace icons in some input types
jholt1
reviewed
Jan 26, 2022
packages/library/components/inputter/src/inputter-detail-styles.css
Outdated
Show resolved
Hide resolved
jholt1
reviewed
Jan 26, 2022
jholt1
reviewed
Jan 26, 2022
jholt1
reviewed
Jan 26, 2022
jholt1
reviewed
Jan 26, 2022
jholt1
reviewed
Jan 26, 2022
…-engineering/muon into feature/inputter-styles
jholt1
reviewed
Jan 31, 2022
jholt1
reviewed
Jan 31, 2022
jholt1
reviewed
Jan 31, 2022
| `; | ||
| } | ||
| } | ||
|
|
||
| return undefined; | ||
| } | ||
|
|
||
| get _inputTypeIcon() { | ||
| let icon; |
There was a problem hiding this comment.
Don't need a let here can just be a return. But this can be done in another PR
jholt1
reviewed
Jan 31, 2022
| } else { | ||
| this._inputType = this._inputTypes.SINGLE; | ||
| get _inputType() { | ||
| if(!this.__inputType) { |
There was a problem hiding this comment.
This wrapper isn't required, if someone changed the input type this would then not update
There was a problem hiding this comment.
Every time doing querySelector will be a performance issue.
jholt1
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.