Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: light dom style build fix #530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: light dom style build fix #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/muon/muon-element/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const MuonElementMixin = (superClass) => class extends superClass {
__addLightDOM() {
const checkSheets = (styleSheets, styleName) => {
return [].slice.call(styleSheets).filter((sheet) => {
return sheet.title === styleName;
return sheet.ownerNode?.id === styleName;
});
};

Expand All @@ -55,11 +55,13 @@ export const MuonElementMixin = (superClass) => class extends superClass {
const styleName = key > 0 ? `${nodeName}-styles-${key}` : `${nodeName}-styles`;

// First need to replace `light-dom` with the component name
clonedCSS.cssText = clonedCSS.cssText.replace(/light-dom/g, nodeName);
clonedCSS.cssText = clonedCSS.cssText.replace(/import {css} from 'lit';\nexport const styles = css`/g, '');
clonedCSS.cssText = clonedCSS.cssText.replace(/`;\nexport default styles;\n/g, '');

// How we add the styles depends on where it is being added, HTMLDocument or another ShadowDom.
// If the Document we don't want to add multiple times
if (parentNodeType === '#document-fragment') {
clonedCSS.cssText = clonedCSS.cssText.replace(/light-dom/g, nodeName);
// If it is within a shadowDom
let stylesAdded;

Expand All @@ -74,13 +76,14 @@ export const MuonElementMixin = (superClass) => class extends superClass {

adoptStyles(parentNode, stylesAdded);
} else if (parentNodeType === '#document') {
clonedCSS.cssText = clonedCSS.cssText.replace(/light-dom/g, `.ndsn ${nodeName}`);
// If it is in the parent DOM
const styleSheets = parentNode.styleSheets;

if (!Array.from(checkSheets(styleSheets, styleName)).length > 0) {
const style = document.createElement('style');
style.innerHTML = String.raw`${clonedCSS.cssText}`;
style.title = styleName;
style.id = styleName;
document.head.appendChild(style);
}
}
Expand Down