ci: add browserstack and additional browsers #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jholt1
commented
Nov 10, 2021
•
jholt1
commented
- Add greater browser and device test coverage
jholt1
changed the title
| // only one or the other can be installed at once (see our "postinstall" NPM | ||
| // script). See | ||
| // https://modern-web.dev/docs/test-runner/browser-launchers/puppeteer/. | ||
| puppeteerLauncher({ launchOptions: { product: 'firefox' } }), |
There was a problem hiding this comment.
Use environment variable for product defined in test.yml.
There was a problem hiding this comment.
The variable in the GitHub Action is to enforce puppeteer to download the Firefox binary on npm install for ubuntu. If we use the variable here, then everyone who wants to run the tests would need to add the environment variable
MekalaNagarajan-Centrica
approved these changes
Nov 18, 2021
jholt1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.