New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: detail mixin #90

Merged

MekalaNagarajan-Centrica merged 33 commits into main from feature/detail-mixin

Jan 7, 2022

Contributor

MekalaNagarajan-Centrica commented Dec 3, 2021 •

edited

Loading

What is completed?

Detail mixin
Detail component

MekalaNagarajan-Centrica added 7 commits

December 3, 2021 13:13


          feat: detail mixin

17b3f4b


          Merge branch 'main' into feature/detail-mixin

e31a9ff


          chore: update package root

13b8704


          feat: test fixes

4c304b4


          feat: helper component

03bf245


          feat: detail icon

7b6c0ef


          feat: open close icon tokens

0876cf5

jholt1 linked an issue

that may be closed by this pull request

Create details component #24

Closed

18 tasks

jholt1 reviewed

View reviewed changes

packages/library/mixins/detail-mixin.js Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/components/detail/src/styles.css Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/mixins/detail-mixin.js Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/tests/mixins/detail.test.js Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/tests/mixins/detail.test.js Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/tests/mixins/detail.test.js Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/components/detail/src/styles.css Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/tests/mixins/detail.test.js Outdated Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/tests/mixins/detail.test.js Outdated Show resolved Hide resolved

andij reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Outdated Show resolved Hide resolved

andij reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Outdated Show resolved Hide resolved

andij reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Outdated Show resolved Hide resolved

andij reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Outdated Show resolved Hide resolved

andij reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Outdated Show resolved Hide resolved


          feat: icon position

andij reviewed

View reviewed changes

packages/library/mixins/detail-mixin.js Outdated Show resolved Hide resolved


          fix: icon position for detail component

17610c3

jholt1 reviewed

View reviewed changes

packages/library/components/inputter/src/inputter-component.js Outdated Show resolved Hide resolved

Contributor

jholt1 commented Dec 8, 2021

For the test did you try the oneEvent helper? https://open-wc.org/docs/testing/helpers/#testing-events


          Merge branch 'main' into feature/detail-mixin

68caddf

Contributor Author

MekalaNagarajan-Centrica commented Dec 8, 2021

I tried using oneEvent, but test timedout while waiting for the event. So I have to fallback to sinon library

andij approved these changes

View reviewed changes

andij and others added 16 commits

December 10, 2021 14:41


          Merge branch 'main' into feature/detail-styles

88f7ca3


          feat: toggle icon position css

6222dbf


          Merge branch 'feature/detail-mixin' into feature/detail-styles

b18e5d7


          chore: adjust story for details

6af0e4f


          feat: css selector

438f7c0


          feat: styles and tokens for detail component

0e400c4


          Merge branch 'feature/detail-mixin' into feature/detail-styles

acdd564


          feat: reduce dom depth


          feat: rename toggle-icon to toggle

9fb4b9a


          Merge branch 'main' into feature/detail-styles

59daee0


          Merge branch 'main' into feature/detail-mixin

2b70f22


          Merge branch 'feature/detail-mixin' into feature/detail-styles

b62c96d


          revert: unnecessarily quoted property 'details'

ad94d31


          feat: test fixes

688cbae


          Merge branch 'main' into feature/detail-mixin

7151b81


          Merge branch 'feature/detail-mixin' into feature/detail-styles

097b3f2

jholt1 reviewed

View reviewed changes

packages/library/tests/mixins/detail.test.js Show resolved Hide resolved

andij and others added 4 commits

December 16, 2021 13:54


          Merge pull request #124 from centrica-engineering/feature/detail-styles

250bf19

Feature/detail styles


          feat: content indent for toggle-start

bb2d542


          test: cleanup

012e626


          Merge branch 'feature/detail-mixin' of https://github.com/centrica-en…

363b566

…gineering/muon into feature/detail-mixin

jholt1 reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Show resolved Hide resolved

jholt1 reviewed

View reviewed changes

packages/library/components/detail/src/detail-component.js Outdated Show resolved Hide resolved

MekalaNagarajan-Centrica and others added 2 commits

January 4, 2022 15:04


          fix: icon in mixin

a3889f7


          Merge branch 'main' into feature/detail-mixin

a7eea63

MekalaNagarajan-Centrica requested a review from jholt1

January 5, 2022 16:15

jholt1 approved these changes

View reviewed changes

MekalaNagarajan-Centrica merged commit 92dde2b into main

andij deleted the feature/detail-mixin branch

February 1, 2022 09:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet