add more missing hasOwnProperty checks

centrifugal · Oct 4, 2023 · ed5fc95 · ed5fc95
1 parent dc4a1f7
commit ed5fc95
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/centrifuge.ts b/src/centrifuge.ts
@@ -1823,6 +1823,9 @@ export class Centrifuge extends (EventEmitter as new () => TypedEventEmitter<Cli
 
  private _resolvePromises() {
  for (const id in this._promises) {
+ if (!this._promises.hasOwnProperty(id)) {
+ continue;
+ }
  if (this._promises[id].timeout) {
  clearTimeout(this._promises[id].timeout);
  }
@@ -1833,6 +1836,9 @@ export class Centrifuge extends (EventEmitter as new () => TypedEventEmitter<Cli
 
  private _rejectPromises(err: any) {
  for (const id in this._promises) {
+ if (!this._promises.hasOwnProperty(id)) {
+ continue;
+ }
  if (this._promises[id].timeout) {
  clearTimeout(this._promises[id].timeout);
  }

diff --git a/src/subscription.ts b/src/subscription.ts
@@ -463,6 +463,9 @@ export class Subscription extends (EventEmitter as new () => TypedEventEmitter<S
 
  private _resolvePromises() {
  for (const id in this._promises) {
+ if (!this._promises.hasOwnProperty(id)) {
+ continue;
+ }
  if (this._promises[id].timeout) {
  clearTimeout(this._promises[id].timeout);
  }
@@ -473,6 +476,9 @@ export class Subscription extends (EventEmitter as new () => TypedEventEmitter<S
 
  private _rejectPromises(err: any) {
  for (const id in this._promises) {
+ if (!this._promises.hasOwnProperty(id)) {
+ continue;
+ }
  if (this._promises[id].timeout) {
  clearTimeout(this._promises[id].timeout);
  }