Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Delta Fossil Compression #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mahdibn
Copy link

@Mahdibn Mahdibn commented Sep 15, 2024

No description provided.

@Mahdibn Mahdibn closed this Sep 15, 2024
@Mahdibn Mahdibn reopened this Sep 15, 2024
@FZambia
Copy link
Member

FZambia commented Sep 20, 2024

Hello @Mahdibn

Thanks! But we still need the code which implements Fossil algorithm to decode deltas.

@Mahdibn
Copy link
Author

Mahdibn commented Sep 21, 2024

Hello @Mahdibn

Thanks! But we still need the code which implements Fossil algorithm to decode deltas.

Hello @FZambia
Ahh ok I will add it as well 👍🏻

@Mahdibn Mahdibn changed the title Added delta parameter to subscribe request - to support delta fossil compression Implemented Delta Fossil Compression Sep 21, 2024
@Mahdibn
Copy link
Author

Mahdibn commented Sep 21, 2024

Hello @FZambia,
I've just pushed an update to the PR that includes the implementation of the Fossil decoding algorithm. Please take a look when you have a chance and let me know if you have any further feedback.

@FZambia
Copy link
Member

FZambia commented Sep 21, 2024

@Mahdibn hello, this is cool! Could you please add test test cases to Fossil algorithm implementation? I think it's very important to have. Probably re-use tests cases from other Fossil algorithm implementations? Ex. https://github.com/dchest/fossil-delta-js/tree/master/test

@Mahdibn
Copy link
Author

Mahdibn commented Sep 21, 2024

@Mahdibn hello, this is cool! Could you please add test test cases to Fossil algorithm implementation? I think it's very important to have. Probably re-use tests cases from other Fossil algorithm implementations? Ex. https://github.com/dchest/fossil-delta-js/tree/master/test

Hello @FZambia,
yes sure I will add them 👍🏻

@FZambia
Copy link
Member

FZambia commented Oct 1, 2024

Thanks the updates! I see this error in CI:

/Users/runner/work/centrifuge-swift/centrifuge-swift/Tests/SwiftCentrifugeTests/DeltaFossilTests.swift:32: error: -[SwiftCentrifugeTests.DeltaFossilTests testDeltaCreateAndApply] : failed - Could not find file origin
Test Case '-[SwiftCentrifugeTests.DeltaFossilTests testDeltaCreateAndApply]' failed (0.803 seconds).

Probably related to current working directory used during test run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants