emulation logging tweaks (#326)

centrifugal · Oct 22, 2023 · 94a03a1 · 94a03a1
1 parent f88d21a
commit 94a03a1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/emulation.go b/emulation.go
@@ -53,11 +53,11 @@ func (s *EmulationHandler) ServeHTTP(rw http.ResponseWriter, r *http.Request) {
 
  data, err := io.ReadAll(r.Body)
  if err != nil {
+ s.node.logger.log(newLogEntry(LogLevelInfo, "error reading emulation request body", map[string]any{"error": err.Error()}))
  if len(data) >= maxBytesSize {
  rw.WriteHeader(http.StatusRequestEntityTooLarge)
  return
  }
- s.node.logger.log(newLogEntry(LogLevelError, "can't read emulation request body", map[string]any{"error": err.Error()}))
  rw.WriteHeader(http.StatusInternalServerError)
  return
  }
@@ -69,7 +69,9 @@ func (s *EmulationHandler) ServeHTTP(rw http.ResponseWriter, r *http.Request) {
  err = json.Unmarshal(data, &req)
  }
  if err != nil {
- s.node.logger.log(newLogEntry(LogLevelInfo, "can't unmarshal emulation request", map[string]any{"req": &req, "error": err.Error()}))
+ if s.node.LogEnabled(LogLevelInfo) {
+ s.node.logger.log(newLogEntry(LogLevelInfo, "can't unmarshal emulation request", map[string]any{"error": err.Error(), "data": string(data)}))
+ }
  rw.WriteHeader(http.StatusBadRequest)
  return
  }

diff --git a/handler_http_stream.go b/handler_http_stream.go
@@ -61,7 +61,7 @@ func (h *HTTPStreamHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
  var err error
  requestData, err = io.ReadAll(r.Body)
  if err != nil {
- h.node.Log(NewLogEntry(LogLevelError, "error reading body", map[string]any{"error": err.Error()}))
+ h.node.Log(NewLogEntry(LogLevelInfo, "error reading http stream request body", map[string]any{"error": err.Error()}))
  if len(requestData) >= maxBytesSize {
  w.WriteHeader(http.StatusRequestEntityTooLarge)
  return

diff --git a/handler_sse.go b/handler_sse.go
@@ -61,11 +61,11 @@ func (h *SSEHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
  var err error
  requestData, err = io.ReadAll(r.Body)
  if err != nil {
+ h.node.Log(NewLogEntry(LogLevelInfo, "error reading sse request body", map[string]any{"error": err.Error()}))
  if len(requestData) >= maxBytesSize {
  w.WriteHeader(http.StatusRequestEntityTooLarge)
  return
  }
- h.node.Log(NewLogEntry(LogLevelError, "error reading body", map[string]any{"error": err.Error()}))
  w.WriteHeader(http.StatusInternalServerError)
  return
  }