Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on already subscribed error #390

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Jun 19, 2024

This fixes a panic introduced in 2188a02. panic: close of closed channel happened in case of already subscribed error.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (f41c0bf) to head (3a48b1b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
+ Coverage   81.47%   81.59%   +0.11%     
==========================================
  Files          40       40              
  Lines        7100     7107       +7     
==========================================
+ Hits         5785     5799      +14     
+ Misses        941      936       -5     
+ Partials      374      372       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia merged commit 4023c34 into master Jun 19, 2024
8 checks passed
@FZambia FZambia deleted the fix_panic_on_already_subscribed branch June 19, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant