Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fossil delta construction in recovered publications #415

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Oct 5, 2024

This PR fixes wrong delta construction for recovered publications. The bug resulted into bad checksum errors on the client side. Also, added test for this.

PR also contains trace log improvements, we now handle json marshaling errors using fallback to protojson.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (f3e8061) to head (584666d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
client.go 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   81.38%   81.55%   +0.16%     
==========================================
  Files          40       40              
  Lines        7204     7210       +6     
==========================================
+ Hits         5863     5880      +17     
+ Misses        965      947      -18     
- Partials      376      383       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia merged commit cb46d6b into master Oct 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant