Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log connection duration as string #416

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Log connection duration as string #416

merged 1 commit into from
Oct 5, 2024

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Oct 5, 2024

Makes debug logs more human readable.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (cb46d6b) to head (b2efced).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
handler_http_stream.go 0.00% 1 Missing ⚠️
handler_sse.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   81.63%   81.55%   -0.09%     
==========================================
  Files          40       40              
  Lines        7210     7210              
==========================================
- Hits         5886     5880       -6     
- Misses        944      949       +5     
- Partials      380      381       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia merged commit 640bd94 into master Oct 5, 2024
8 checks passed
@FZambia FZambia deleted the log_duration_string branch October 5, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant