Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect accrual asset transactions after payments #234

Closed
hieronx opened this issue Aug 9, 2024 · 1 comment · Fixed by #247
Closed

Fix incorrect accrual asset transactions after payments #234

hieronx opened this issue Aug 9, 2024 · 1 comment · Fixed by #247
Assignees
@filo87
Labels
Bug Something isn't working

Comments

@hieronx
Copy link
Contributor

hieronx commented Aug 9, 2024

Accrual asset transactions are negative after fees were paid, see https://app.centrifuge.io/#/pools/4139607887/reporting/fee-tx:

Screenshot 2024-08-09 at 09 50 54
@filo87
Copy link
Collaborator

filo87 commented Aug 9, 2024

Probably missing subtracting payment

@filo87 filo87 added the Bug Something isn't working label Aug 13, 2024
@filo87 filo87 self-assigned this Aug 26, 2024
filo87 added a commit that referenced this issue Aug 26, 2024
@filo87
fix: fix incorrect accrual asset transactions after payments
723e72a 
Fixes #234
@filo87 filo87 mentioned this issue Aug 27, 2024
Merged
@filo87 filo87 closed this as completed in c91fc4a Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filo87 filo87

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wrong poolFees historical values centrifuge/pools-subql
2 participants
@hieronx @filo87