Skip to content

cephadm-adopt: Fixes binding network for alertmanager (backport #7576) #3029

cephadm-adopt: Fixes binding network for alertmanager (backport #7576)

cephadm-adopt: Fixes binding network for alertmanager (backport #7576) #3029

Triggered via pull request August 5, 2024 12:03
Status Success
Total duration 2m 35s
Artifacts

ansible-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 12 warnings
name[play]: dashboard.yml#L2
All plays should be named.
fqcn[action-core]: dashboard.yml#L15
Use FQCN for builtin module actions (set_stats).
name[casing]: dashboard.yml#L15
All names should start with an uppercase letter.
run-once[task]: dashboard.yml#L15
Using run_once may behave differently if strategy is set to free.
fqcn[action-core]: dashboard.yml#L24
Use FQCN for builtin module actions (import_role).
name[missing]: dashboard.yml#L24
All tasks should be named.
fqcn[action-core]: dashboard.yml#L27
Use FQCN for builtin module actions (import_role).
name[missing]: dashboard.yml#L27
All tasks should be named.
fqcn[action-core]: dashboard.yml#L30
Use FQCN for builtin module actions (import_role).
name[missing]: dashboard.yml#L30
All tasks should be named.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-python@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jinja[spacing]: infrastructure-playbooks/cephadm-adopt.yml#L109
Jinja2 spacing could be improved: groups.get((grafana_server_group_name|default('grafana-server')), []) | length > 0 -> groups.get((grafana_server_group_name | default('grafana-server')), []) | length > 0
jinja[spacing]: infrastructure-playbooks/cephadm-adopt.yml#L498
Jinja2 spacing could be improved: {{ ((mirror_pool_info.stdout | default('{}') | from_json)['peers'] | selectattr('site_name', 'match', '^'+ceph_rbd_mirror_remote_cluster+'$') | map(attribute='uuid') | list) }} -> {{ ((mirror_pool_info.stdout | default('{}') | from_json)['peers'] | selectattr('site_name', 'match', '^' + ceph_rbd_mirror_remote_cluster + '$') | map(attribute='uuid') | list) }}
jinja[spacing]: infrastructure-playbooks/cephadm-adopt.yml#L523
Jinja2 spacing could be improved: {{ admin_rbd_cmd }} mirror pool peer remove {{ ceph_rbd_mirror_pool }} {{ ((mirror_pool_info.stdout | default('{}') | from_json)['peers'] | selectattr('site_name', 'match', '^'+ceph_rbd_mirror_remote_cluster+'$') | map(attribute='uuid') | list)[0] }} -> {{ admin_rbd_cmd }} mirror pool peer remove {{ ceph_rbd_mirror_pool }} {{ ((mirror_pool_info.stdout | default('{}') | from_json)['peers'] | selectattr('site_name', 'match', '^' + ceph_rbd_mirror_remote_cluster + '$') | map(attribute='uuid') | list)[0] }}
jinja[spacing]: infrastructure-playbooks/filestore-to-bluestore.yml#L276
Jinja2 spacing could be improved: {{ osd_fsid_list | default([]) + [{'osd_fsid': item.tags['ceph.osd_fsid'], 'destroy': (item.lv_name.startswith('osd-data-') and item.vg_name.startswith('ceph-')) | ternary(true, false), 'device': item.devices[0], 'journal': item['tags']['ceph.journal_device'] }] }} -> {{ osd_fsid_list | default([]) + [{'osd_fsid': item.tags['ceph.osd_fsid'], 'destroy': (item.lv_name.startswith('osd-data-') and item.vg_name.startswith('ceph-')) | ternary(true, false), 'device': item.devices[0], 'journal': item['tags']['ceph.journal_device']}] }}
jinja[spacing]: infrastructure-playbooks/purge-cluster.yml#L515
Jinja2 spacing could be improved: {{ item.data_vg|default(omit) }} -> {{ item.data_vg | default(omit) }}
jinja[spacing]: infrastructure-playbooks/purge-cluster.yml#L515
Jinja2 spacing could be improved: {{ item.db_vg|default(omit) }} -> {{ item.db_vg | default(omit) }}
jinja[spacing]: infrastructure-playbooks/purge-cluster.yml#L515
Jinja2 spacing could be improved: {{ item.db|default(omit) }} -> {{ item.db | default(omit) }}
jinja[spacing]: infrastructure-playbooks/purge-cluster.yml#L515
Jinja2 spacing could be improved: {{ item.journal_vg|default(omit) }} -> {{ item.journal_vg | default(omit) }}
jinja[spacing]: infrastructure-playbooks/purge-cluster.yml#L515
Jinja2 spacing could be improved: {{ item.journal|default(omit) }} -> {{ item.journal | default(omit) }}
jinja[spacing]: infrastructure-playbooks/purge-cluster.yml#L515
Jinja2 spacing could be improved: {{ item.wal_vg|default(omit) }} -> {{ item.wal_vg | default(omit) }}