add playbook to migrate systemd unit to podman #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
guits-podman_migration_dedicated_playbook
branch
from
4144714 to
cf0b268
Compare
guits
force-pushed
the
guits-podman_migration_dedicated_playbook
branch
2 times, most recently
from
2cafab2 to
a717554
Compare
guits
changed the title
guits
force-pushed
the
guits-podman_migration_dedicated_playbook
branch
from
a717554 to
8f8dcfe
Compare
guits
force-pushed
the
guits-podman_migration_dedicated_playbook
branch
2 times, most recently
from
fc0fe90 to
ed99c34
Compare
guits
force-pushed
the
guits-podman_migration_dedicated_playbook
branch
6 times, most recently
from
0f48575 to
922793d
Compare
|
jenkins test dev-centos-container-podman |
|
@guits found the issue. I think you removed a taks during the iscsi containerized/systemd refact. 91bef94#diff-8543c5196317a6a1ae0edd3392ba0f23R2 Without this task, the rbd-target-{api,gw} services don't start. |
This commit isolates the systemd unit files generation for containers into separate yml files in order to be able importing each corresponding roles without playing all tasks. This is needed so we can run ceph-ansible to render systemd unit files so they call podman instead of docker. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
this commit adds a new playbook to force systemd units for containers to use podman instead of docker. This is needed in the rhel8 upgrade context so after the base OS is upgraded containers can be started using podman. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This commit moves containerized deployment related files to `./tasks/ directory. This is needed to make `docker-to-podman.yml` working since we use `tasks_from:` option. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This commit moves containerized deployment related files to `./tasks/` directory. This is needed to make `docker-to-podman.yml` working since we use `tasks_from:` option. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This commit moves containerized deployment related files to `./tasks/` directory. This is needed to make `docker-to-podman.yml` working since we use `tasks_from:` option. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
rename this file to be more generic. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
dsavineau
force-pushed
the
guits-podman_migration_dedicated_playbook
branch
from
922793d to
3cae54b
Compare
|
@guits I've rebased this PR to include the missing code |
|
jenkins test pipeline |
|
jenkins test dev-centos-non_container-all_daemons |
|
jenkins test dev-centos-container-all_daemons |
dsavineau
approved these changes
Oct 1, 2019
guits
added a commit
that referenced
this pull request
Aug 10, 2021
pr #4319 introduced some uesless `become: true` on systemd tasks. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 18, 2021
pr #4319 introduced some uesless `become: true` on systemd tasks. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
stuartgrace-bbc
pushed a commit
to bbc/ceph-ansible
that referenced
this pull request
Jan 30, 2024
pr ceph#4319 introduced some uesless `become: true` on systemd tasks. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds a new playbook to force systemd units for containers to
use podman instead of docker.
This is needed in the rhel8 upgrade context so after the base OS is upgraded containers can be started using podman.
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com