[skip ci] purge: playbooks refactor #6719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
clean_purge_playbook
branch
6 times, most recently
from
d8938d1 to
f831305
Compare
|
jenkins test centos-container-purge |
guits
force-pushed
the
clean_purge_playbook
branch
from
f831305 to
2c67fbd
Compare
|
jenkins test centos-container-purge |
|
jenkins test centos-non_container-purge |
guits
force-pushed
the
clean_purge_playbook
branch
from
2c67fbd to
fd60410
Compare
|
jenkins test centos-non_container-purge |
|
jenkins test centos-container-purge |
guits
force-pushed
the
clean_purge_playbook
branch
from
fd60410 to
e4c2081
Compare
|
jenkins test centos-container-purge |
|
jenkins test centos-non_container-purge |
Those variables are useless given this is not possible to override them. Let's replace them with the hardcoded name instead. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This refactor merges the two playbooks so we only have to maintain 1 playbook. (Symlink the old purge-container-cluster.yml playbook for backward compatibility). Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
clean_purge_playbook
branch
from
e4c2081 to
a4fe670
Compare
guits
force-pushed
the
clean_purge_playbook
branch
from
010dcf0 to
e2a91bd
Compare
|
jenkins test centos-non_container-purge |
|
jenkins test centos-container-purge |
dsavineau
changed the title
dsavineau
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
This looks good.
The only minor comment would be to update the documentation but this can probably be done in a dedicated PR.
https://github.com/ceph/ceph-ansible/blob/master/docs/source/day-2/purge.rst
This was referenced Jul 22, 2021
guits
added a commit
that referenced
this pull request
Aug 11, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 11, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 16, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 16, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 16, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 16, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 17, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
added a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
dsavineau
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 09ef465) # Conflicts: # infrastructure-playbooks/cephadm-adopt.yml
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 09ef465)
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 09ef465)
dsavineau
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 09ef465)
dsavineau
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 09ef465)
dsavineau
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 09ef465)
dsavineau
pushed a commit
that referenced
this pull request
Aug 18, 2021
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR #6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 09ef465)
stuartgrace-bbc
pushed a commit
to bbc/ceph-ansible
that referenced
this pull request
Jan 30, 2024
This adds ceph-*.target systemd unit files support for containerized deployments. This also fixes a regression introduced by PR ceph#6719 (rgw and nfs systemd units not getting purged) Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1962748 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor merges the two playbooks so we only have to maintain 1
playbook.
(Symlink the old purge-container-cluster.yml playbook for backward
compatibility).
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com