-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver Controller: Ensure CSI Config Creation #104
Conversation
Instead of watching for delete events can't we add the driver as the ownerRef if the configmap already exists and we don't need to consider delete events? |
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
f568c90
to
71956cb
Compare
We are already adding the driver as an owner ref. But there is still a need to watch for delete events for the case where the configmap goes away and need to be recreated. The delete filter makes sure that we are not queuing an based on create or update events |
Sorry am failing to understand it as we are adding the owner ref if the configmap already exists how it will go away if the driver is not deleted? Do you mean the use will manually remove the configmap by hand? |
Yes. If a controller takes the responsibility to move a system toward a certain actual state it also needs to take the responsibility to readjust if that actual state has changed (for any reason) |
Describe what this PR does
If a driver CR exists but no client profile CR exists, any container that needs to mount the
ceph-csi-config
config map will fail. To solve the issue, the following behavior is added:ceph-csi-config
config map if not already exist and adds an owner refceph-csi-config
config map