Fix issue 149 - add some CI workflows #153
Conversation
|
This is marked as draft since it does not cover all points of #149 yet. |
|
@Madhu-1 what remains is to add the stale workflow. Any special requirements for this one or is it OK to use the rook workflow as a start? https://github.com/rook/rook/blob/master/.github/workflows/stale.yaml |
|
add some CI worjflows -> add some CI workflows |
obnoxxx
changed the title
|
@parth-gr wrote:
good catch, thanks! fixed. |
|
replying to myself:
I used that file as a basis after confirmation from @Madhu-1 on chat. |
|
LGTM |
|
marked ready for review since all items of #149 are addressed. |
obnoxxx
force-pushed
the
fix-149
branch
3 times, most recently
from
ff400ac to
1b3f675
Compare
for background information, see https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review and https://github.com/actions/dependency-review-action Signed-off-by: Michael Adam <obnox@samba.org>
This assigns an issue to a github user who comments '`/assign` based on https://github.com/rook/rook/blob/master/.github/workflows/auto-assign.yaml Signed-off-by: Michael Adam <obnox@samba.org>
The mod.check target verifies and tidies the go module dependencies. Signed-off-by: Michael Adam <obnox@samba.org>
obnoxxx
force-pushed
the
fix-149
branch
3 times, most recently
from
1422d65 to
8611ca5
Compare
obnoxxx
force-pushed
the
fix-149
branch
2 times, most recently
from
acc5610 to
3f88ca5
Compare
Signed-off-by: Michael Adam <obnox@samba.org>
This workflow periodically scans issues and PRs to mark inactive items stale and close them after continued inactivity. Based on the rook project's workflow: https://github.com/rook/rook/blob/master/.github/workflows/stale.yaml Signed-off-by: Michael Adam <obnox@samba.org>
Describe what this PR does
This PR adds some github workflows to the CI as requested in #149
Is there anything that requires special attention
mod.checkmaketarget to be easily invoked locally by developers
Do you have any questions?
no questiions at this time.
Is the change backward compatible?
It should be backward compatible.
Provide any external context for the change, if any.
none.
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #149
Future concerns
no future concerns currently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.